Skip to content

Stop compiling when we get resolving crate failure#154713

Merged
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
chenyukang:yukang-fix-154096-missing-crate-noise
Apr 3, 2026
Merged

Stop compiling when we get resolving crate failure#154713
rust-bors[bot] merged 3 commits intorust-lang:mainfrom
chenyukang:yukang-fix-154096-missing-crate-noise

Conversation

@chenyukang
Copy link
Copy Markdown
Member

@chenyukang chenyukang commented Apr 2, 2026

Fixes #154096

closes #118130

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 2, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 2, 2026

r? @TaKO8Ki

rustbot has assigned @TaKO8Ki.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 69 candidates
  • Random selection from 12 candidates

Copy link
Copy Markdown
Member

@Kivooeo Kivooeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with ci green

View changes since this review

@chenyukang
Copy link
Copy Markdown
Member Author

@bors r=kivooeo

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 2, 2026

📌 Commit f1fbfd4 has been approved by kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Apr 2, 2026
…ng-crate-noise, r=kivooeo

Stop compiling when we get resolving crate failure

Fixes rust-lang#154096

closes rust-lang#118130
rust-bors bot pushed a commit that referenced this pull request Apr 2, 2026
…uwer

Rollup of 21 pull requests

Successful merges:

 - #153105 (Compute the result of a projection type with region errors)
 - #153286 (various fixes for scalable vectors)
 - #153532 (Attributes containing rustc)
 - #153960 (Make `layout_of` cycles fatal errors)
 - #154527 (Emit pre-expansion feature gate warnings for negative impls and specialization)
 - #154666 (Remove `StableHashContext` impls)
 - #154669 (Introduce #[diagnostic::on_move] on `Arc`)
 - #154710 (opaque_generic_const_args -> generic_const_args)
 - #154712 (Revert "`-Znext-solver` Remove the forced ambiguity hack from search graph")
 - #154713 (Stop compiling when we get resolving crate failure)
 - #154213 (tidy-alphabetical: fix line number in error message)
 - #154425 (Migrate transmute tests)
 - #154442 (Export `derive` at the crate root: `core::derive` and `std::derive`)
 - #154469 (mGCA: Lower spans for literal const args)
 - #154578 (Rename `probe_ty_var` to `try_resolve_ty_var`)
 - #154615 (Moving issues)
 - #154644 (rustdoc: seperate methods and associated functions in sidebar)
 - #154660 (Avoid creating async return opaques for foreign async fns)
 - #154671 (Add a test for a past ICE when calling a const fn of an unresolved type with the wrong number of args)
 - #154680 ([rustdoc] Replace `DocContext` with `TyCtxt` wherever possible)
 - #154709 (Revert `Ty` type alias in `rustc_type_ir`)
@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors r-
Probably the cause of #154716 (comment)
@bors try jobs=dist-various-1

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 2, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 2, 2026

This pull request was unapproved.

This PR was contained in a rollup (#154716), which was unapproved.

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Apr 2, 2026
…ise, r=<try>

Stop compiling when we get resolving crate failure


try-job: dist-various-1
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 2, 2026

💔 Test for 558670d failed: CI. Failed job:

@rust-log-analyzer

This comment has been minimized.

@chenyukang
Copy link
Copy Markdown
Member Author

@bors try jobs=dist-various-1

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
…ise, r=<try>

Stop compiling when we get resolving crate failure


try-job: dist-various-1
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 3, 2026

☀️ Try build successful (CI)
Build commit: fdd3e3f (fdd3e3fa80a247d8eb5b1f569b7fdb417ca512ea, parent: 55e86c996809902e8bbad512cfb4d2c18be446d9)

@chenyukang
Copy link
Copy Markdown
Member Author

@bors r=kivooeo

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Apr 3, 2026

📌 Commit cd95593 has been approved by kivooeo

It is now in the queue for this repository.

@rust-bors rust-bors bot added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 3, 2026
@rust-bors rust-bors bot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 3, 2026
rust-bors bot pushed a commit that referenced this pull request Apr 3, 2026
Rollup of 6 pull requests

Successful merges:

 - #154696 (rustdoc_missing_doc_code_examples: lint on macro_rules macros)
 - #154698 (Improve workings of the `desc` query modifier and custom query cycle handlers)
 - #154713 (Stop compiling when we get resolving crate failure)
 - #154736 (Add a regression test for the duplicated `crate` keyword in path suggestions)
 - #154739 (ci: update upload-artifact action to v7)
 - #154741 (Enforce `#![warn(unreachable_pub)]` in compiletest source)

Failed merges:

 - #154605 (Make `span_suggestions` always verbose)
@rust-bors rust-bors bot merged commit c0c22d1 into rust-lang:main Apr 3, 2026
12 checks passed
@rustbot rustbot added this to the 1.96.0 milestone Apr 3, 2026
rust-timer added a commit that referenced this pull request Apr 3, 2026
Rollup merge of #154713 - chenyukang:yukang-fix-154096-missing-crate-noise, r=kivooeo

Stop compiling when we get resolving crate failure

Fixes #154096

closes #118130
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

100s of irrelevant errors when a crate cannot be loaded rustc should not try to analyze the crate after "multiple candidates" messages

6 participants